Bug 206180 - [EWS] Status bubble tooltip might display success message sometimes on a failed build
Summary: [EWS] Status bubble tooltip might display success message sometimes on a fail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-13 10:06 PST by Aakash Jain
Modified: 2020-01-14 17:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.24 KB, patch)
2020-01-14 15:39 PST, Aakash Jain 		jbedard: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-01-13 10:06:42 PST 
[EWS] Status bubble tooltip might display success message sometimes on a failed build if the last step in the build succeeds. For the failed builds, status bubble tooltip displays the message from the last step. If the last step is successful (but some other step failed), it might be misleading.

e.g.: https://ews-build.webkit.org/#/builders/20/builds/11444
Comment 1 Aakash Jain 2020-01-14 15:39:57 PST 
Created attachment 387715 [details]
Patch
Comment 2 Aakash Jain 2020-01-14 15:44:18 PST 
Tested in https://ews.webkit-uat.org/status-bubble/387402/
Comment 3 Aakash Jain 2020-01-14 17:08:36 PST 
Committed r254545: <https://trac.webkit.org/changeset/254545>
Comment 4 Radar WebKit Bug Importer 2020-01-14 17:09:35 PST 
<rdar://problem/58588995>