Bug 206104 - Expose frame information on _WKResourceLoadInfo
Summary: Expose frame information on _WKResourceLoadInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-10 15:38 PST by Alex Christensen
Modified: 2020-01-11 17:48 PST (History)
3 users (show)

See Also:

Attachments
Patch (24.35 KB, patch)
2020-01-10 15:43 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (24.55 KB, patch)
2020-01-10 16:14 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (24.55 KB, patch)
2020-01-10 16:57 PST, Alex Christensen 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-01-10 15:38:13 PST 
Expose frame information on _WKResourceLoadInfo
Comment 1 Alex Christensen 2020-01-10 15:43:17 PST 
Created attachment 387387 [details]
Patch
Comment 2 Alex Christensen 2020-01-10 16:14:15 PST 
Created attachment 387390 [details]
Patch
Comment 3 Alex Christensen 2020-01-10 16:57:50 PST 
Created attachment 387398 [details]
Patch
Comment 4 Dean Jackson 2020-01-11 12:37:08 PST 
Comment on attachment 387398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387398&action=review

> Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.mm:93
> +    [coder encodeObject:@([self frameID]) forKey:@"frameID"];

self.frameID ?

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:596
> -    if (page)
> -        loadParameters.pageHasResourceLoadClient = page->hasResourceLoadClient();
> +    addParametersFromFrame(webFrame->coreFrame(), loadParameters);

I assume it is totally ok that the loadParameters here might get .isHTTPSUpgradeEnabled set now, when it didn't before?

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:662
> +    addParametersFromFrame(&frame, loadParameters);

Same here.
Comment 5 Alex Christensen 2020-01-11 17:42:06 PST 
(In reply to Dean Jackson from comment #4)
> I assume it is totally ok that the loadParameters here might get
> .isHTTPSUpgradeEnabled set now, when it didn't before?
Yes, that was an oversight before.  We want https upgrade for sync xhr and beacon.
Comment 6 Alex Christensen 2020-01-11 17:47:04 PST 
http://trac.webkit.org/r254409
Comment 7 Radar WebKit Bug Importer 2020-01-11 17:48:13 PST 
<rdar://problem/58507584>