Bug 206080 - Different statements are cached to same entry in SQLiteIDBBackingStore
Summary: Different statements are cached to same entry in SQLiteIDBBackingStore
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-10 12:03 PST by Sihui Liu
Modified: 2022-02-10 16:50 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2020-01-10 12:05 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-01-10 12:03:16 PST 
...
Comment 1 Sihui Liu 2020-01-10 12:05:30 PST 
Created attachment 387360 [details]
Patch
Comment 2 Sihui Liu 2020-01-13 09:03:23 PST 
ping for review...
Comment 3 youenn fablet 2020-01-13 09:28:45 PST 
Comment on attachment 387360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387360&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1627
> +    auto* sql = cachedStatement(SQL::DeleteObjectStoreIndexRecordWithKey, "DELETE FROM IndexRecords WHERE objectStoreID = ? AND objectStoreRecordID = ? AND key = CAST(? AS TEXT);"_s);

I guess this should be observable, can we write a test?