Bug 206066 - Introduce an abstract SampleBufferDisplayLayer
Summary: Introduce an abstract SampleBufferDisplayLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 206060
Blocks: 206286
  Show dependency tree / graph
 
Reported: 2020-01-10 07:54 PST by youenn fablet
Modified: 2020-01-20 01:19 PST (History)
11 users (show)

See Also:

Attachments
Patch (52.52 KB, patch)
2020-01-10 08:52 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (53.82 KB, patch)
2020-01-10 09:10 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (53.82 KB, patch)
2020-01-10 09:20 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (52.16 KB, patch)
2020-01-13 05:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (54.47 KB, patch)
2020-01-15 05:03 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (54.42 KB, patch)
2020-01-15 05:41 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (54.32 KB, patch)
2020-01-20 00:36 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-01-10 07:54:57 PST 
Introduce an abstract SampleBufferDisplayLayer
Comment 1 youenn fablet 2020-01-10 08:52:47 PST 
Created attachment 387340 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-01-10 08:53:18 PST 
<rdar://problem/58480181>
Comment 3 youenn fablet 2020-01-10 09:10:02 PST 
Created attachment 387343 [details]
Patch
Comment 4 youenn fablet 2020-01-10 09:20:13 PST 
Created attachment 387346 [details]
Patch
Comment 5 Eric Carlson 2020-01-10 09:47:48 PST 
Comment on attachment 387346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387346&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:118
> +            callOnMainThread([protectedSelf = RetainPtr<WebAVSampleBufferStatusChangeListener>(self), layer = WTFMove(layer), status = WTFMove(status)] {

Nit: layer and status aren't used in the lambda.

> Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:129
> +            callOnMainThread([protectedSelf = RetainPtr<WebAVSampleBufferStatusChangeListener>(self), layer = WTFMove(layer), status = WTFMove(status)] {

Ditto
Comment 6 youenn fablet 2020-01-13 05:48:11 PST 
Created attachment 387518 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-14 05:47:50 PST 
Comment on attachment 387518 [details]
Patch

Rejecting attachment 387518 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 387518, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/13303942
Comment 8 youenn fablet 2020-01-15 05:03:42 PST 
Created attachment 387778 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2020-01-15 05:15:33 PST 
Comment on attachment 387778 [details]
Patch for landing

Rejecting attachment 387778 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 387778, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/13304732
Comment 10 youenn fablet 2020-01-15 05:41:20 PST 
Created attachment 387781 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2020-01-15 06:24:16 PST 
Comment on attachment 387781 [details]
Patch for landing

Clearing flags on attachment: 387781

Committed r254564: <https://trac.webkit.org/changeset/254564>
Comment 12 WebKit Commit Bot 2020-01-15 06:24:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Matt Lewis 2020-01-17 16:41:38 PST 
Reverted r254564 for reason:

This caused internal test crashes.

Committed r254779: <https://trac.webkit.org/changeset/254779>
Comment 14 youenn fablet 2020-01-20 00:36:10 PST 
Created attachment 388211 [details]
Patch for landing
Comment 15 WebKit Commit Bot 2020-01-20 01:19:40 PST 
Comment on attachment 388211 [details]
Patch for landing

Clearing flags on attachment: 388211

Committed r254813: <https://trac.webkit.org/changeset/254813>
Comment 16 WebKit Commit Bot 2020-01-20 01:19:42 PST 
All reviewed patches have been landed.  Closing bug.