Bug 205996 - Fix various non-unified build issues introduced since r253538
Summary: Fix various non-unified build issues introduced since r253538
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-09 03:52 PST by Adrian Perez
Modified: 2020-01-09 22:53 PST (History)
19 users (show)

See Also:

Attachments
Patch (7.13 KB, patch)
2020-01-09 07:24 PST, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch for landing (7.21 KB, patch)
2020-01-09 13:57 PST, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-01-09 03:52:09 PST 
First set of fixes for non-unified builds in 2020 :-]
Comment 1 Adrian Perez 2020-01-09 07:24:21 PST 
Created attachment 387225 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-01-09 07:30:55 PST 
Comment on attachment 387225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387225&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [GTK][WPE] Fix various non-unified build issues introduced since r253538

Why is this marked GTK and WPE specific?
Comment 3 Adrian Perez 2020-01-09 07:45:53 PST 
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 387225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387225&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        [GTK][WPE] Fix various non-unified build issues introduced since r253538
> 
> Why is this marked GTK and WPE specific?

Right… no reason whatsoever. Let's remove the tags.
Comment 4 youenn fablet 2020-01-09 08:28:22 PST 
Comment on attachment 387225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387225&action=review

> Source/WebCore/page/PageConfiguration.h:34
> +#include <wtf/text/WTFString.h>

Would <wtf/Forward.h> work here?
Comment 5 Adrian Perez 2020-01-09 13:36:58 PST 
(In reply to youenn fablet from comment #4)
> Comment on attachment 387225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387225&action=review
> 
> > Source/WebCore/page/PageConfiguration.h:34
> > +#include <wtf/text/WTFString.h>
> 
> Would <wtf/Forward.h> work here?

I'll give that a try, thanks for the suggestion.
Comment 6 Adrian Perez 2020-01-09 13:55:39 PST 
(In reply to Adrian Perez from comment #5)
> (In reply to youenn fablet from comment #4)
> > Comment on attachment 387225 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=387225&action=review
> > 
> > > Source/WebCore/page/PageConfiguration.h:34
> > > +#include <wtf/text/WTFString.h>
> > 
> > Would <wtf/Forward.h> work here?
> 
> I'll give that a try, thanks for the suggestion.

Yes, using <wtf/Forward.h> instead of <wtf/text/WTFString.h> worked.
I'll land a version of the patch with this change applied and the
bug title adjusted as per Carlos' suggestion.

As there are mentions to files NarrowingNumberPredictionFuzzerAgent.cpp
and NarrowingNumberPredictionFuzzerAgent.cpp which contain the string
“fuzzer” in them, the style checker complains, so I will land the patch
manually after checking that the EWS bots build with the patch fine :)
Comment 7 Adrian Perez 2020-01-09 13:57:03 PST 
Created attachment 387269 [details]
Patch for landing
Comment 8 Adrian Perez 2020-01-09 22:52:09 PST 
Committed r254327: <https://trac.webkit.org/changeset/254327>
Comment 9 Radar WebKit Bug Importer 2020-01-09 22:53:14 PST 
<rdar://problem/58471112>