Bug 205976 - Web Inspector: suggest "color()" when defining color in CSS value
Summary: Web Inspector: suggest "color()" when defining color in CSS value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-08 17:30 PST by Nikita Vasilyev
Modified: 2020-01-09 17:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2020-01-08 17:31 PST, Nikita Vasilyev 		hi: review+
Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2020-01-09 16:38 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-01-08 17:30:20 PST 
Suggest "color()" the same way we suggest "rgb()" or "hsl()".
Comment 1 Nikita Vasilyev 2020-01-08 17:31:56 PST 
Created attachment 387169 [details]
Patch
Comment 2 Devin Rousso 2020-01-08 18:18:41 PST 
Comment on attachment 387169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387169&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:314
> +    "wheat", "whitesmoke", "yellowgreen", "rgb()", "rgba()", "hsl()", "hsla()", "color()"

Style: please add a trailing comma
Comment 3 Nikita Vasilyev 2020-01-09 16:38:39 PST 
Created attachment 387289 [details]
Patch
Comment 4 WebKit Commit Bot 2020-01-09 17:24:33 PST 
Comment on attachment 387289 [details]
Patch

Clearing flags on attachment: 387289

Committed r254316: <https://trac.webkit.org/changeset/254316>
Comment 5 WebKit Commit Bot 2020-01-09 17:24:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-09 17:25:18 PST 
<rdar://problem/58464614>