Bug 205965 - [PlayStation] Enable WebKit
Summary: [PlayStation] Enable WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on: 205964 206186 206198 206243 206247 206267 206320 206323 206324
Blocks:
  Show dependency tree / graph
 
Reported: 2020-01-08 15:49 PST by Don Olmstead
Modified: 2020-01-16 15:16 PST (History)
10 users (show)

See Also:

Attachments
WIP Patch (33.17 KB, patch)
2020-01-14 13:43 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
WIP Patch (33.14 KB, patch)
2020-01-14 13:44 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
WIP Patch (31.36 KB, patch)
2020-01-14 13:56 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (39.89 KB, patch)
2020-01-16 14:02 PST, Don Olmstead 		ross.kirsling: review+
Details | Formatted Diff | Diff
Patch (38.44 KB, patch)
2020-01-16 14:47 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-01-08 15:49:03 PST 
Enable WebKit for the PlayStation port
Comment 1 Don Olmstead 2020-01-14 13:43:03 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-01-14 13:44:20 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-01-14 13:56:09 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2020-01-16 14:02:07 PST 
Created attachment 387954 [details]
Patch
Comment 5 Ross Kirsling 2020-01-16 14:36:42 PST 
Comment on attachment 387954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387954&action=review

r=me with nits

> Source/WebKit/Platform/unix/ModuleUnix.cpp:40
> +void* Module::platformFunctionPointer(const char* functionName) const

Seems like we should recheck the newly-added files for unused param names like this one.

> Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp:43
> +    return nullptr; // static_cast<PageClientImpl&>(pageClient()).viewBackend();

The commented-out code in this file seems like it should be removed.
Comment 6 Don Olmstead 2020-01-16 14:47:43 PST 
Created attachment 387963 [details]
Patch

Fix the nits
Comment 7 WebKit Commit Bot 2020-01-16 15:15:04 PST 
Comment on attachment 387963 [details]
Patch

Clearing flags on attachment: 387963

Committed r254713: <https://trac.webkit.org/changeset/254713>
Comment 8 WebKit Commit Bot 2020-01-16 15:15:06 PST 
All reviewed patches have been landed.  Closing bug.