Bug 205895 - Add a testing target to make that is release + assertions
Summary: Add a testing target to make that is release + assertions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 16:26 PST by Keith Miller
Modified: 2020-01-07 17:56 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.25 KB, patch)
2020-01-07 16:26 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (6.23 KB, patch)
2020-01-07 16:38 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-01-07 16:26:07 PST 
Add a testing target to make that is release + assertions
Comment 1 Keith Miller 2020-01-07 16:26:37 PST 
Created attachment 387051 [details]
Patch
Comment 2 Mark Lam 2020-01-07 16:36:38 PST 
Comment on attachment 387051 [details]
Patch

r=me but make sure ASSERT_ENABLED is set to 1.
Comment 3 Keith Miller 2020-01-07 16:38:37 PST 
Created attachment 387052 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-01-07 17:55:29 PST 
Comment on attachment 387052 [details]
Patch for landing

Clearing flags on attachment: 387052

Committed r254181: <https://trac.webkit.org/changeset/254181>
Comment 5 WebKit Commit Bot 2020-01-07 17:55:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-07 17:56:16 PST 
<rdar://problem/58395245>