Bug 205892 - [LFC] FormattingContext::layoutOutOfFlowContent should take horizontal and vertical constraints.
Summary: [LFC] FormattingContext::layoutOutOfFlowContent should take horizontal and ve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 15:09 PST by zalan
Modified: 2020-01-09 09:37 PST (History)
6 users (show)

See Also:

Attachments
Patch (30.44 KB, patch)
2020-01-07 15:17 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (30.51 KB, patch)
2020-01-09 08:50 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-07 15:09:18 PST 
instead of reading the containing block's geometry.
Comment 1 Radar WebKit Bug Importer 2020-01-07 15:09:44 PST 
<rdar://problem/58389802>
Comment 2 zalan 2020-01-07 15:17:26 PST 
Created attachment 387043 [details]
Patch
Comment 3 Antti Koivisto 2020-01-09 07:18:52 PST 
Comment on attachment 387043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387043&action=review

> Source/WebCore/layout/LayoutContext.cpp:101
> +    // It constructs an FC for descendant boxes and runs layout on them. The formattingContextRoot is laied out in the FC in which it lives (parent formatting context).

typo 'laied'
Comment 4 zalan 2020-01-09 08:50:22 PST 
Created attachment 387236 [details]
Patch
Comment 5 WebKit Commit Bot 2020-01-09 09:37:07 PST 
Comment on attachment 387236 [details]
Patch

Clearing flags on attachment: 387236

Committed r254263: <https://trac.webkit.org/changeset/254263>
Comment 6 WebKit Commit Bot 2020-01-09 09:37:08 PST 
All reviewed patches have been landed.  Closing bug.