Bug 99948

Summary:

Move LayoutTests/fast/css3-text-decoration directory into LayoutTests/fast/css3-text directory.

Product:

WebKit

Reporter:

Dongwoo Joshua Im (dwim) <dw.im>

Component:

CSS

Assignee:

Dongwoo Joshua Im (dwim) <dw.im>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, donggwan.kim, gyuyoung.kim, jchaffraix, rakuco, webkit.review.bot

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

99804

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Dongwoo Joshua Im (dwim)

Reported 2012-10-21 19:48:50 PDT

Regarding the modification of the flag, I think css3-text-decoration directory should be moved into css3-text directory. LayoutTests/fast/css3-text directory will have these sub-directories. 1. css3-text-decoration 2. css3-text-align-last : regarding https://bugs.webkit.org/show_bug.cgi?id=76173 3. css3-text-justify : regarding https://bugs.webkit.org/show_bug.cgi?id=99945

Attachments
Patch (129.16 KB, patch) 2012-10-21 19:58 PDT, Dongwoo Joshua Im (dwim)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dongwoo Joshua Im (dwim)

Comment 1 2012-10-21 19:58:11 PDT

Created attachment 169824 [details] Patch

Hajime Morrita

Comment 2 2012-10-22 01:20:20 PDT

Comment on attachment 169824 [details] Patch rs=me

WebKit Review Bot

Comment 3 2012-10-22 01:45:50 PDT

Comment on attachment 169824 [details] Patch Clearing flags on attachment: 169824 Committed r132043: <http://trac.webkit.org/changeset/132043>

WebKit Review Bot

Comment 4 2012-10-22 01:45:54 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 5 2012-10-22 04:00:27 PDT

After this patch, we have 3 new failures on the EFL build bots: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132058%20(4843)/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-pretty-diff.html http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132058%20(4843)/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-pretty-diff.html http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132058%20(4843)/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-pretty-diff.html

Dongwoo Joshua Im (dwim)

Comment 6 2012-10-22 04:21:33 PDT

(In reply to comment #5) > After this patch, we have 3 new failures on the EFL build bots: > http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132058%20(4843)/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-pretty-diff.html > > http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132058%20(4843)/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-pretty-diff.html > > http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132058%20(4843)/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-pretty-diff.html I've fixed this by https://bugs.webkit.org/show_bug.cgi?id=99974. Sorry for this.

Note You need to log in before you can comment on or make changes to this bug.