Bug 99918

Summary: [mac] Text with zero font size renders as 12px sometimes
Product: WebKit Reporter: mitz
Component: TextAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, ggaren, ossy, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100115    
Bug Blocks:    
Attachments:
Description Flags
Make Font::drawGlyphs() bail out if the font size is 0 none

mitz
Reported 2012-10-20 17:38:24 PDT
[mac] Text with zero font size renders as 12px sometimes
Attachments
Make Font::drawGlyphs() bail out if the font size is 0 (3.10 KB, patch)
2012-10-20 17:45 PDT, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-10-20 17:38:55 PDT
<rdar://problem/12512710>
mitz
Comment 2 2012-10-20 17:45:31 PDT
Created attachment 169778 [details] Make Font::drawGlyphs() bail out if the font size is 0
Geoffrey Garen
Comment 3 2012-10-20 18:48:47 PDT
Comment on attachment 169778 [details] Make Font::drawGlyphs() bail out if the font size is 0 View in context: https://bugs.webkit.org/attachment.cgi?id=169778&action=review r=me > LayoutTests/fast/text/zero-font-size-2.html:4 > + l o r e m i s u m d o l o r I believe you are missing a 'p'.
WebKit Review Bot
Comment 4 2012-10-20 18:52:40 PDT
Comment on attachment 169778 [details] Make Font::drawGlyphs() bail out if the font size is 0 Attachment 169778 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14462993 New failing tests: fast/text/zero-font-size-2.html
mitz
Comment 5 2012-10-20 18:52:54 PDT
(In reply to comment #3) > (From update of attachment 169778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169778&action=review > > r=me > > > LayoutTests/fast/text/zero-font-size-2.html:4 > > + l o r e m i s u m d o l o r > > I believe you are missing a 'p'. The Ahem lowercase p is a thin rectangle below the baseline, and I wanted the failure case to show a simple red rectangle, so I dropped it. Thanks for the review!
mitz
Comment 6 2012-10-20 18:55:18 PDT
(In reply to comment #4) > (From update of attachment 169778 [details]) > Attachment 169778 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/14462993 > > New failing tests: > fast/text/zero-font-size-2.html I wonder if the Font implementation used by chromium-xvfb has a bug similar to this. I suppose after I commit this patch I’ll be able to see what the failure looks like.
mitz
Comment 7 2012-10-20 18:57:58 PDT
Fixed in <http://trac.webkit.org/r131995>.
mitz
Comment 8 2012-10-20 19:46:36 PDT
(In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 169778 [details] [details]) > > Attachment 169778 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/14462993 > > > > New failing tests: > > fast/text/zero-font-size-2.html > > I wonder if the Font implementation used by chromium-xvfb has a bug similar to this. I suppose after I commit this patch I’ll be able to see what the failure looks like. Indeed, the results at <http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r131995%20(40063)/fast/text/zero-font-size-2-diffs.html> confirm this. I’ve filed bug 99920.
Csaba Osztrogonác
Comment 9 2012-10-25 03:43:14 PDT
I filed a new bug report to fix this fail on Qt too - https://bugs.webkit.org/show_bug.cgi?id=100115
Note You need to log in before you can comment on or make changes to this bug.