Bug 99745

Summary:

LLInt backends of non-ARM RISC platforms should be able to share code with the existing ARMv7 backend

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, kbalazs, loki, mark.lam, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ggaren: review+

Filip Pizlo

Reported 2012-10-18 12:03:52 PDT

Currently armv7.rb contains loads of useful lowering phases for transforming programs in the offlineasm language into a form more amenable to code generation on ARM. But in fact, most of these phases are generally useful for any RISC target, like MIPS, for example. We should take those things in armv7.rb that are more broadly useful and factor them out into a separate file so that future LLInt ports don't have to copy-paste code.

Attachments
the patch (39.22 KB, patch) 2012-10-20 12:17 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-10-20 12:17:37 PDT

Created attachment 169770 [details] the patch

Geoffrey Garen

Comment 2 2012-10-20 12:31:06 PDT

Comment on attachment 169770 [details] the patch r=me

Filip Pizlo

Comment 3 2012-10-20 13:08:20 PDT

Landed in http://trac.webkit.org/changeset/131989

Note You need to log in before you can comment on or make changes to this bug.