Bug 99495

Summary: html5-full-render.html test uses substring but meant substr
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: Tools / TestsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jamesr, kling, rniwa, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99657    
Attachments:
Description Flags
Patch none

Elliott Sprehn
Reported 2012-10-16 13:25:19 PDT
html5-full-render.html test uses substring but meant substr
Attachments
Patch (1.56 KB, patch)
2012-10-16 13:26 PDT, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2012-10-16 13:26:19 PDT
Created attachment 169010 [details] Patch
Elliott Sprehn
Comment 2 2012-10-16 23:30:45 PDT
For context see: https://bugs.webkit.org/show_bug.cgi?id=95117#c59
Adam Barth
Comment 3 2012-10-16 23:32:07 PDT
Comment on attachment 169010 [details] Patch Really Eric should review this patch, but Elliott asked me to look at it and I think Eric is asleep.
Eric Seidel (no email)
Comment 4 2012-10-16 23:34:04 PDT
It looks fantastic to me. Aside from teh fact that JS has braindead apis.
Eric Seidel (no email)
Comment 5 2012-10-16 23:34:42 PDT
CCing folks who might see the perf bump and be surprised. :)
Elliott Sprehn
Comment 6 2012-10-16 23:42:59 PDT
This reduces the size of the HTML loaded in the test dramatically from 33.5m to 6.5m chars (and subsequently means tens of thousands of fewer DOM nodes) which should create a pretty big "perf win" in the graphs.
WebKit Review Bot
Comment 7 2012-10-16 23:50:50 PDT
Comment on attachment 169010 [details] Patch Clearing flags on attachment: 169010 Committed r131553: <http://trac.webkit.org/changeset/131553>
WebKit Review Bot
Comment 8 2012-10-16 23:50:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.