Bug 99331

Summary: We should avoid weakCompareAndSwap when parallel GC is disabled
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Blocker CC: fpizlo, gaborb, galpeter, loki, ossy, rgabor, zherczeg
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79668, 98792    
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Mark Hahnenberg
Reported 2012-10-15 08:34:11 PDT
CopiedBlock::reportLiveBytes uses weakCompareAndSwap, which some platforms don't support. For platforms that don't have parallel GC enabled, we should just use a normal store.
Attachments
Patch (2.07 KB, patch)
2012-10-15 08:39 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (2.10 KB, patch)
2012-10-15 09:08 PDT, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-10-15 08:39:28 PDT
Created attachment 168718 [details] Patch
Mark Hahnenberg
Comment 2 2012-10-15 08:41:18 PDT
*** Bug 99328 has been marked as a duplicate of this bug. ***
Mark Hahnenberg
Comment 3 2012-10-15 09:08:51 PDT
Created attachment 168727 [details] Patch
Filip Pizlo
Comment 4 2012-10-15 10:31:48 PDT
Comment on attachment 168727 [details] Patch You could have also said ENABLE(COMPARE_AND_SWAP)
Mark Hahnenberg
Comment 5 2012-10-15 10:35:19 PDT
Committed r131318: <http://trac.webkit.org/changeset/131318>
Note You need to log in before you can comment on or make changes to this bug.