Bug 99269

Summary: DFG should handle polymorphic array modes by eagerly transforming arrays into the most general applicable form
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 98606, 99260    
Attachments:
Description Flags
work in progress
none
the patch ggaren: review+

Filip Pizlo
Reported 2012-10-14 12:41:49 PDT
If we see a use of both Contiguous and ArrayStorage, we should just convert to ArrayStorage instead of handling both. Similarly, in the future when we have Int32 and Double arrays, and we see a use of both Int32 and Double, we should just convert to Double instead of handling both. This should be a speed-up and a huge simplification, since the current "polymorphic" modes require a lot of code.
Attachments
work in progress (24.94 KB, patch)
2012-10-14 17:26 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (34.57 KB, patch)
2012-10-14 18:18 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-10-14 14:03:20 PDT
*** This bug has been marked as a duplicate of bug 99260 ***
Filip Pizlo
Comment 2 2012-10-14 16:57:19 PDT
On second thought, I'm going to do this separately from https://bugs.webkit.org/show_bug.cgi?id=99260.
Filip Pizlo
Comment 3 2012-10-14 17:26:46 PDT
Created attachment 168601 [details] work in progress
Filip Pizlo
Comment 4 2012-10-14 18:18:47 PDT
Created attachment 168603 [details] the patch
Geoffrey Garen
Comment 5 2012-10-14 19:09:39 PDT
Comment on attachment 168603 [details] the patch r=me
Filip Pizlo
Comment 6 2012-10-14 20:18:52 PDT
Landed in http://trac.webkit.org/changeset/131289
Note You need to log in before you can comment on or make changes to this bug.