Bug 98492

Summary:

Web Inspector: More granular filtering on message type.

Product:

WebKit

Reporter:

Mike West <mkwst>

Component:

Web Inspector (Deprecated)

Assignee:

Dmitry Zvorygin <zvorygin>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

addyo, burg, dubroy, japhet, mkwst+watchlist, paulirish, pfeldman, vivekgalatage, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Sample screenshot.	none
Sample screenshot.	none
Patch	pfeldman: review-
Decreased checkbox size and lighter dropdown arrow separator.	none

Mike West

Reported 2012-10-05 00:44:25 PDT

Report from a user: ------------------- "Please let the Errors Warnings and Logs behave like checkboxes instead of radio buttons. For instance when you want to see Errors *and* Logs but not Warnings."

Attachments
Patch (36.18 KB, patch) 2013-03-15 04:33 PDT, Dmitry Zvorygin	no flags	Details Formatted Diff Diff
Sample screenshot. (53.04 KB, image/png) 2013-03-18 04:40 PDT, Dmitry Zvorygin	no flags	Details
Sample screenshot. (51.45 KB, image/png) 2013-03-18 04:41 PDT, Dmitry Zvorygin	no flags	Details
Patch (36.30 KB, patch) 2013-03-19 03:49 PDT, Dmitry Zvorygin	pfeldman: review-	Details Formatted Diff Diff
Decreased checkbox size and lighter dropdown arrow separator. (37.18 KB, image/png) 2013-03-19 03:51 PDT, Dmitry Zvorygin	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Vivek Galatage

Comment 1 2012-10-05 13:40:56 PDT

(In reply to comment #0) > Report from a user: > ------------------- > > "Please let the Errors Warnings and Logs behave like checkboxes instead of radio buttons. For instance when you want to see Errors *and* Logs but not Warnings." Is this referring to the console panel? If yes then we already support this with help of meta key press (ctrl in case of linux/windows) + click. We can selectively click while having the meta key pressed. Correct me if I am wrong.

Mike West

Comment 2 2013-01-24 06:10:38 PST

*** Bug 107704 has been marked as a duplicate of this bug. ***

Mike West

Comment 3 2013-01-24 06:29:52 PST

Widening the scope of this bug a bit: we have "sources" and "severities". It should be possible to filter on both. Pavel's suggestion: "I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source)."

Mike West

Comment 4 2013-01-24 06:34:41 PST

Slightly more explanation: Console messages have (at least) two properties that are interesting: "source" and "level". Currently, we offer filtering on the latter via the weird "Error", "Warning", "Log", "Debug" quasi-checkboxes at the bottom of the console. We offer no filtering on the former (which includes sources like "HTML", "JS", "Network", "XML", and "Other"). Based on some discussion in https://bugs.webkit.org/show_bug.cgi?id=107704, it seems like we should. I'd like to come up with some sort of UI that reasonably presents this matrix of filters to users.

Addy Osmani

Comment 5 2013-01-24 06:39:36 PST

> we already support this with help of meta key press (ctrl in case of linux/windows) + click On the narrower scope: I agree with Mike that checkboxes would be more intuitive - until Vivek mentioned we supported multiple selection via ctrl + click, I had no idea this was supported. Something more user-friendly would almost certainly be better. > I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source) Is it possible to see a rough mock-up for what this might look like? :) In my mind it feels overly complex, but my visualization may be incorrect.

Addy Osmani

Comment 6 2013-01-24 06:41:03 PST

> We offer no filtering on the former (which includes sources like "HTML", "JS", "Network", "XML", and "Other") Agreed that filtering on these messages would be useful. I'm surprised this isn't currently supported to be honest.

Dmitry Zvorygin

Comment 7 2013-03-15 04:33:13 PDT

Created attachment 193279 [details] Patch

Vsevolod Vlasov

Comment 8 2013-03-18 00:32:39 PDT

Comment on attachment 193279 [details] Patch Could you please attach screenshots?

Dmitry Zvorygin

Comment 9 2013-03-18 04:40:46 PDT

Created attachment 193528 [details] Sample screenshot.

Dmitry Zvorygin

Comment 10 2013-03-18 04:41:23 PDT

Created attachment 193529 [details] Sample screenshot. Please note, that checkbox at "Other" has gone away.

Dmitry Zvorygin

Comment 11 2013-03-19 03:49:31 PDT

Created attachment 193777 [details] Patch

Dmitry Zvorygin

Comment 12 2013-03-19 03:51:36 PDT

Created attachment 193778 [details] Decreased checkbox size and lighter dropdown arrow separator.

Pavel Feldman

Comment 13 2013-03-19 09:36:56 PDT

The font should be on "0 of 0" (i.e. smaller). Also, you should check the looks on a Mac.

Pavel Feldman

Comment 14 2013-03-19 09:45:21 PDT

(In reply to comment #13) > The font should be on "0 of 0" (i.e. smaller). Also, you should check the looks on a Mac. (sorry, wrong bug)

Pavel Feldman

Comment 15 2013-03-19 09:48:01 PDT

Comment on attachment 193777 [details] Patch You should split this change into 1) the one normalizing the levels 2) migrating to the non-CSS filtering 3) introducing new UI widgets. Also, please decrease the font 1px for the filter labels.

Brian Burg

Comment 16 2014-12-01 14:31:16 PST

Current inspector supports multiple selection.

Note You need to log in before you can comment on or make changes to this bug.