Bug 98389

Summary: [EFL] Run unit tests with Xvfb
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: alexander.shalamov, bw80.lee, d-r, gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98231    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-10-04 02:44:02 PDT
We currently unset the DISPLAY environment variable in setup_environ_for_server() if the variable is not set on the system. This is an issue now because XvfbDriver sets the DISPLAY environment variable and we don't want to unset it on the bots (where the system does not have DISPLAY environment variable set).
Attachments
Patch (4.02 KB, patch)
2012-10-04 06:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-04 02:49:07 PDT
Our unit tests are failing because of this. We wrongly unset the DISPLAY environment variable and then ecore_x_init() fails on the bots.
Chris Dumez
Comment 2 2012-10-04 06:38:10 PDT
Created attachment 167095 [details] Patch This patch fixes unit tests on our build bots by running them with Xvfb.
Laszlo Gombos
Comment 3 2012-10-04 07:37:48 PDT
Comment on attachment 167095 [details] Patch r=me.
WebKit Review Bot
Comment 4 2012-10-04 07:45:27 PDT
Comment on attachment 167095 [details] Patch Clearing flags on attachment: 167095 Committed r130390: <http://trac.webkit.org/changeset/130390>
WebKit Review Bot
Comment 5 2012-10-04 07:45:31 PDT
All reviewed patches have been landed. Closing bug.
Byungwoo Lee
Comment 6 2012-10-05 00:16:20 PDT
*** Bug 98414 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.