Bug 98369

Summary: [GTK] accessibility/language-attribute.html is failing
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: apinheiro, cfleizach, dmazzoni, jdiggs, webkit.review.bot
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98347    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-10-04 00:41:29 PDT
accessibility/language-attribute.html is failing on all GTK platforms. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=accessibility%2Flanguage-attribute.html
Attachments
Patch (7.72 KB, patch)
2012-12-09 16:13 PST, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joanmarie Diggs
Comment 1 2012-10-16 13:01:04 PDT
This is failing for two reasons: * We're not exposing the language for the object (should be an AtkText attribute) * AccessibilityUIElement::language() needs to be implemented
Joanmarie Diggs
Comment 2 2012-12-09 16:13:21 PST
Created attachment 178447 [details] Patch
Joanmarie Diggs
Comment 3 2012-12-09 16:40:46 PST
Comment on attachment 178447 [details] Patch EWS all green, small patch, hoping it will pass Martin's review, so cq?ing.
chris fleizach
Comment 4 2012-12-09 23:45:52 PST
Comment on attachment 178447 [details] Patch looks good
WebKit Review Bot
Comment 5 2012-12-10 00:18:53 PST
Comment on attachment 178447 [details] Patch Clearing flags on attachment: 178447 Committed r137114: <http://trac.webkit.org/changeset/137114>
WebKit Review Bot
Comment 6 2012-12-10 00:18:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.