Bug 97833

Summary: Encapsulate private properties in PerfTestRunner better
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, eric, haraken, morrita, ojan, tkent, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97743, 97852    
Bug Blocks: 77037    
Attachments:
Description Flags
Cleanup
none
Fixed a test ojan: review+

Ryosuke Niwa
Reported 2012-09-27 17:23:50 PDT
Right now, "private" properties of PerfTestRunner are just regular properties prefixed with _. We can do better by enclosing everything in a closure.
Attachments
Cleanup (18.09 KB, patch)
2012-09-28 14:50 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed a test (18.08 KB, patch)
2012-09-28 14:51 PDT, Ryosuke Niwa 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-09-28 14:50:03 PDT
Created attachment 166315 [details] Cleanup
Ryosuke Niwa
Comment 2 2012-09-28 14:51:51 PDT
Created attachment 166316 [details] Fixed a test
Ojan Vafai
Comment 3 2012-10-01 16:41:15 PDT
Comment on attachment 166316 [details] Fixed a test This is fine. A less fragile approach would be to wrap the whole file in an anonymous function and at the end of the function only expose the things you really want to expose, e.g.: window.PerfTestRunner = PerfTestRunner; That way, everything is private by default and people don't need to move code around to enable it to use a private helper function.
Ryosuke Niwa
Comment 4 2012-10-01 16:43:51 PDT
(In reply to comment #3) > (From update of attachment 166316 [details]) > This is fine. A less fragile approach would be to wrap the whole file in an anonymous function and at the end of the function only expose the things you really want to expose, e.g.: Yup. I'm doing that in a follow up. I'm just trying to make the diff unreadable.
Ryosuke Niwa
Comment 5 2012-10-01 16:44:02 PDT
*readable.
Ryosuke Niwa
Comment 6 2012-10-01 16:47:55 PDT
Committed r130099: <http://trac.webkit.org/changeset/130099>
Note You need to log in before you can comment on or make changes to this bug.