Bug 97784

Summary: REGRESSION (r129742): Nightly builds crash on launch
Product: WebKit Reporter: Sveto <svetloslav>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: andersca, bdakin, cgarcia, cruz.ryan, dykstrad, fabian, invalidname, jimoase, jonlee, kevin, lars.sonchocky-helldorf, mario
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.7   
URL: http%3A%2F%2F
Attachments:
Description Flags
Crash report none

Sveto
Reported 2012-09-27 07:28:04 PDT
Cache deleted, website icons delete. Still r129743 crashes on launch shortly before the start page completes loading.
Attachments
Crash report (45.68 KB, text/plain)
2012-09-27 07:34 PDT, Sveto 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Sveto
Comment 1 2012-09-27 07:34:51 PDT
Created attachment 165995 [details] Crash report This crash report was invoked while the ClickToPlugin was disabled to avoid influencing the result.
Alexey Proskuryakov
Comment 2 2012-09-27 09:34:57 PDT
*** Bug 97788 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 3 2012-09-27 09:35:17 PDT
*** Bug 97782 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 4 2012-09-27 09:36:02 PDT
Occurs on 10.7 and 10.8. <rdar://problem/12386144>
Alexey Proskuryakov
Comment 5 2012-09-27 09:46:45 PDT
r129742 is the only revision in the range that touches icon code, so I'm blaming it. Mario, can you look into this soon, or should the revision be rolled out?
Carlos Garcia Campos
Comment 6 2012-09-27 10:21:18 PDT
Looking at r129742 I don't find anything wrong, but I agree it looks like the commit to blame. The new method is added to the end of the client, so I guess we don't need to increase the interface version. I can't make it crash with GTK+ port.
Mario Sanchez Prada
Comment 7 2012-09-27 11:43:56 PDT
(In reply to comment #5) > r129742 is the only revision in the range that touches icon code, so I'm blaming it. > > Mario, can you look into this soon, or should the revision be rolled out? I'm looking into it now
Mario Sanchez Prada
Comment 8 2012-09-27 12:26:31 PDT
We forgot to bump the new version of WKIconDatabaseClient. A fix has been already committed: http://trac.webkit.org/changeset/129789
Alexey Proskuryakov
Comment 9 2012-09-27 14:57:14 PDT
*** Bug 97819 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 10 2012-09-27 14:58:01 PDT
Marking FIXED per Mario's comment.
Alexey Proskuryakov
Comment 11 2012-09-27 14:58:48 PDT
*** Bug 97809 has been marked as a duplicate of this bug. ***
Jim Oase
Comment 12 2012-09-27 15:31:31 PDT
build r129786 also crashes on launch
Kevin M. Dean
Comment 13 2012-09-27 17:29:57 PDT
(In reply to comment #12) > build r129786 also crashes on launch That's because the fix isn't until r129789+
Alexey Proskuryakov
Comment 14 2012-09-28 09:44:34 PDT
*** Bug 97906 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 15 2012-09-28 09:44:46 PDT
*** Bug 97844 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.