Bug 97721

Summary: [CSS Exclusions] Test that dynamically setting shape-inside causes relayout in child elements
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256, 97704    
Attachments:
Description Flags
Initial patch none

Bear Travis
Reported 2012-09-26 13:11:04 PDT
Make sure setting shape-inside causes relayout when children contain inline content <div style="shape-inside:..."> <div> I am inline content </div> </div>
Attachments
Initial patch (4.94 KB, patch)
2012-10-29 17:14 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2012-10-29 17:14:06 PDT
Created attachment 171342 [details] Initial patch
Dirk Schulze
Comment 2 2012-10-31 06:23:56 PDT
Comment on attachment 171342 [details] Initial patch View in context: https://bugs.webkit.org/attachment.cgi?id=171342&action=review > LayoutTests/fast/exclusions/resources/simple-rectangle.js:29 > + if (content) > + elem.innerHTML = content; This seems more then a restriction then an addition. Can you explain it in more detail what you aim to do and why you did it?
Bear Travis
Comment 3 2012-10-31 10:33:07 PDT
The goal for this test is to add a shape-inside dynamically to an element with block children, and make sure it lays out correctly. The previous tests all added shape-inside and content at the same time, via the script. The added conditional allows us to skip passing in a content argument, leaving the element's existing innerHTML in place. Does this make sense? Deserve a comment in the changelog or js file?
WebKit Review Bot
Comment 4 2012-10-31 18:21:46 PDT
Comment on attachment 171342 [details] Initial patch Clearing flags on attachment: 171342 Committed r133106: <http://trac.webkit.org/changeset/133106>
WebKit Review Bot
Comment 5 2012-10-31 18:21:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.