Bug 97640

Summary: Rename ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, gyuyoung.kim, macpherson, menard, mifenton, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97299, 97633    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-09-26 00:26:28 PDT
We would like to rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI to apply other date/time input types.
Attachments
Patch 1 (34.01 KB, patch)
2012-09-26 01:43 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-26 01:43:15 PDT
Created attachment 165750 [details] Patch 1
yosin
Comment 2 2012-09-26 01:44:04 PDT
Comment on attachment 165750 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-09-26 01:57:12 PDT
Comment on attachment 165750 [details] Patch 1 ok Please make sure this patch doesn't break any build and any tests.
yosin
Comment 4 2012-09-26 02:01:30 PDT
Comment on attachment 165750 [details] Patch 1 Clearing flags on attachment: 165750 Committed r129612: <http://trac.webkit.org/changeset/129612>
yosin
Comment 5 2012-09-26 02:01:37 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 6 2012-09-26 02:02:55 PDT
Please update http://trac.webkit.org/wiki/FeatureFlags
Kent Tamura
Comment 7 2012-09-27 18:09:21 PDT
(In reply to comment #6) > Please update http://trac.webkit.org/wiki/FeatureFlags ping
yosin
Comment 8 2012-09-27 18:17:50 PDT
(In reply to comment #7) > (In reply to comment #6) > > Please update http://trac.webkit.org/wiki/FeatureFlags > > ping I updated the wiki.
Kent Tamura
Comment 9 2012-09-27 18:21:20 PDT
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Please update http://trac.webkit.org/wiki/FeatureFlags > > > > ping > > I updated the wiki. Please remove INPUT_TYPE_TIME_MULTIPLE_FIELDS. We don't need to keep a non-existing flag.
yosin
Comment 10 2012-09-27 18:25:14 PDT
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #6) > > > > Please update http://trac.webkit.org/wiki/FeatureFlags > > > > > > ping > > > > I updated the wiki. > > Please remove INPUT_TYPE_TIME_MULTIPLE_FIELDS. We don't need to keep a non-existing flag. Removed.
Note You need to log in before you can comment on or make changes to this bug.