Bug 97611

Summary: run-perf-tests: cleanup options and results generation code
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, morrita, ojan, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97601    
Bug Blocks: 97613    
Attachments:
Description Flags
Patch dpranke: review+

Ryosuke Niwa
Reported 2012-09-25 15:18:06 PDT
run-perf-tests: cleanup options and results generation code
Attachments
Patch (16.43 KB, patch)
2012-09-25 15:30 PDT, Ryosuke Niwa 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-09-25 15:30:30 PDT
Created attachment 165687 [details] Patch
Ryosuke Niwa
Comment 2 2012-09-25 15:31:36 PDT
Once this patch is landed, I'll update master.cfg to use new options.
Ryosuke Niwa
Comment 3 2012-09-25 15:33:21 PDT
Note that master.cfg change cannot be landed until all perf. bots cycle.
Dirk Pranke
Comment 4 2012-09-25 18:25:30 PDT
Comment on attachment 165687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165687&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:109 > + help="Deprecated. Overrides --slave-config-json-path."), Can you just use destination='slave_config_json_path' here?
Ryosuke Niwa
Comment 5 2012-09-25 18:32:06 PDT
Committed r129580: <http://trac.webkit.org/changeset/129580>
Csaba Osztrogonác
Comment 6 2012-09-25 20:50:36 PDT
FYI:It made the output of perf test malformed. See the Qt perf bot for details.
Ryosuke Niwa
Comment 7 2012-09-25 21:23:30 PDT
Yeah, this should be fixed by https://trac.webkit.org/changeset/129589. Additionally, I'm recovering results for these runs so there should be no data loss. Sorry about the noise.
Note You need to log in before you can comment on or make changes to this bug.