Bug 97060

Summary: [V8] Remove WorkerContextExecutionProxy::runScript()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97057    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-09-18 19:28:54 PDT
To kill WorkerContextExecutionProxy, we can remove WorkerContextExecutionProxy::runScript().
Attachments
Patch (6.17 KB, patch)
2012-09-18 19:40 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-09-18 19:40:30 PDT
Created attachment 164645 [details] Patch
Adam Barth
Comment 2 2012-09-19 11:31:15 PDT
Comment on attachment 164645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review > Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274 > - if (script.IsEmpty()) > - return v8::Local<v8::Value>(); This check is missing from ScriptRunner::runCompiledScript. I guess its not needed?
WebKit Review Bot
Comment 3 2012-09-19 11:51:56 PDT
Comment on attachment 164645 [details] Patch Clearing flags on attachment: 164645 Committed r129026: <http://trac.webkit.org/changeset/129026>
WebKit Review Bot
Comment 4 2012-09-19 11:52:00 PDT
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 5 2012-09-19 17:08:45 PDT
Comment on attachment 164645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review >> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274 >> - return v8::Local<v8::Value>(); > > This check is missing from ScriptRunner::runCompiledScript. I guess its not needed? It's not needed in ScriptRunner::runCompiledScript, but was needed in WorkerContextExecutionProxy::runScript (because line 267 can generate an empty script).
Note You need to log in before you can comment on or make changes to this bug.