Bug 96604

Summary: [EFL][WK2] Make _ref() functions return the object
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
gyuyoung.kim: review+
Patch for landing none

Chris Dumez
Reported 2012-09-12 23:10:35 PDT
We should make the *_ref() functions return the object in Ewk APIs to make it more convenient to use: e.g. the following: ewk_download_job_ref(ewkDownload); ewkContext->downloadJobs.add(downloadId, ewkDownload); is replaced by: ewkContext->downloadJobs.add(downloadId, ewk_download_job_ref(ewkDownload)); This is consistent with eina_stringshare_ref() API in EFL and g_object_ref() in glib.
Attachments
Patch (19.83 KB, patch)
2012-09-12 23:22 PDT, Chris Dumez 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
Patch for landing (19.84 KB, patch)
2012-09-13 00:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-09-12 23:22:39 PDT
Created attachment 163787 [details] Patch
Chris Dumez
Comment 2 2012-09-12 23:24:23 PDT
Of course, I'll update the EFL coding guidelines when this lands.
Gyuyoung Kim
Comment 3 2012-09-12 23:37:54 PDT
Comment on attachment 163787 [details] Patch Looks good refactoring.
Gyuyoung Kim
Comment 4 2012-09-12 23:55:33 PDT
Comment on attachment 163787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163787&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] Make _ref() functions return the object Nit: missing [WK2] prefix.
Chris Dumez
Comment 5 2012-09-13 00:15:08 PDT
Created attachment 163797 [details] Patch for landing Could someone please cq+?
WebKit Review Bot
Comment 6 2012-09-13 00:35:36 PDT
Comment on attachment 163797 [details] Patch for landing Clearing flags on attachment: 163797 Committed r128413: <http://trac.webkit.org/changeset/128413>
WebKit Review Bot
Comment 7 2012-09-13 00:35:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.