Bug 96180
| Summary: | REGRESSION(r127939): It broke fast/js/named-function-expression.html and inspector/debugger/debugger-expand-scope.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | 
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | 
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | barraclough, ggaren | 
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 79666, 96159 | ||
          Csaba Osztrogonác
          
          
          
          
        
        
      --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/js/named-function-expression-expected.txt 
+++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/js/named-function-expression-actual.txt 
@@ -29,9 +29,9 @@
 PASS: (function closure() { return (function() { closure = null; return closure && !this.closure; })(); })() should be true and is.
 PASS: (function closure() { return (function() { return closure && !this.closure; }); })()() should be true and is.
 PASS: (function closure() { return (function() { closure = null; return closure && !this.closure; }); })()() should be true and is.
-PASS: (function closure() { eval("var closure"); return closure == undefined && !this.closure; })() should be true and is.
-PASS: (function closure() { eval("function closure() { }"); return closure != arguments.callee && !this.closure; })() should be true and is.
-PASS: (function closure() { eval("var closure;"); closure = 1; return closure == 1 && !this.closure; })() should be true and is.
+FAIL: (function closure() { eval("var closure"); return closure == undefined && !this.closure; })() should be true but isn't.
+FAIL: (function closure() { eval("function closure() { }"); return closure != arguments.callee && !this.closure; })() should be true but isn't.
+FAIL: (function closure() { eval("var closure;"); closure = 1; return closure == 1 && !this.closure; })() should be true but isn't.
 PASS: (function closure() { eval("var closure"); delete closure; return closure == arguments.callee && !this.closure; })() should be true and is.
 PASS: (function closure() { eval("function closure() { }"); delete closure; return closure == arguments.callee && !this.closure; })() should be true and is.
 PASS: (function closure() { eval("closure = 1;"); return closure == arguments.callee && !this.closure; })() should be true and is.
--- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/inspector/debugger/debugger-expand-scope-expected.txt 
+++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/inspector/debugger/debugger-expand-scope-actual.txt 
@@ -13,8 +13,6 @@
     innerFunctionLocalVar: 2012
     this: Window
     x: 2010
-WindowWith Block
-    innerFunction: function innerFunction(x) {
 Closure
     arguments: Arguments[1]
     makeClosureLocalVar: "local.TextParam"
    | Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. | 
          Geoffrey Garen
          
          
          
          
        
        
      Rolled out in <http://trac.webkit.org/changeset/127987>.