Bug 95962

Summary: Validate CSS Device Adaptation properties and resolve shorthands
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: CSSAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, donggwan.kim, kenneth, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95959    
Attachments:
Description Flags
Patch
none
Patch none

Thiago Marcos P. Santos
Reported 2012-09-06 03:01:31 PDT
Add missing keywords and validate the values attributed to the properties allowed in a viewport rule.
Attachments
Patch (9.12 KB, patch)
2012-09-12 14:49 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Patch (17.70 KB, patch)
2012-11-02 08:51 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-09-12 14:49:56 PDT
Created attachment 163704 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-25 06:56:52 PDT
Comment on attachment 163704 [details] Patch This needs some test
Thiago Marcos P. Santos
Comment 3 2012-11-02 08:51:59 PDT
Created attachment 172069 [details] Patch
Kenneth Rohde Christiansen
Comment 4 2012-11-02 09:05:41 PDT
Comment on attachment 172069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172069&action=review > Source/WebCore/css/CSSParser.cpp:2867 > + // Properties bellow are validated inside parseViewportProperty, because we below* > Source/WebCore/css/CSSParser.cpp:10469 > + if (id == CSSValueAuto) > + validPrimitive = true; > + else > + validPrimitive = (!id && validUnit(value, FNumber | FPercent | FNonNeg)); > + break; why not validPrimitive = (id == CSSValueAuto) || .... > LayoutTests/css3/device-adapt/viewport-properties-validation.html:102 > + zoom: 60%; > + letter-spacing: 0.5em; > + } Why not testing max-zoom outside etc.
Kenneth Rohde Christiansen
Comment 5 2012-11-02 09:30:37 PDT
Comment on attachment 172069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172069&action=review >> LayoutTests/css3/device-adapt/viewport-properties-validation.html:102 >> + } > > Why not testing max-zoom outside etc. You are, but a bit up .foo { }, sorry
Alexis Menard (darktears)
Comment 6 2012-11-05 04:22:37 PST
Comment on attachment 172069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172069&action=review >> Source/WebCore/css/CSSParser.cpp:10469 >> + break; > > why not validPrimitive = (id == CSSValueAuto) || .... but the way he wrote it follows the style of the file e.g. line 2140 for example.
WebKit Review Bot
Comment 7 2012-11-05 04:48:12 PST
Comment on attachment 172069 [details] Patch Clearing flags on attachment: 172069 Committed r133458: <http://trac.webkit.org/changeset/133458>
WebKit Review Bot
Comment 8 2012-11-05 04:48:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.