Bug 95748
| Summary: | TestWebKitAPI's WTF.Lrint has four failing asserts on Android | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Beverloo <peter> |
| Component: | Tools / Tests | Assignee: | Peter Beverloo <peter> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | d-r |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Peter Beverloo
Revision 127001 introduced the WTF.Lrint tests, which seem to have a 32/64bit mismatch when run on Android. Both sizeof(long int) and sizeof(long) yield 32 and it seems to default to the NDK's lrint().
I don't have time to follow up immediately, but will eventually get around to doing it. Dominik, since these tests aren't being run on any bots yet it's not reasonable to ask you to take a look, but if you have any immediate ideas that'd be most welcome of course :-).
E/chromium(13749): [ RUN ] WTF.Lrint
E/chromium(13749): *** Failure in ../../Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:44
E/chromium(13749): Value of: pow(2.0, 52)
E/chromium(13749): Actual: 4.5036e+15
E/chromium(13749): Expected: lrint(pow(2.0, 52) - 0.5)
E/chromium(13749): Which is: 2147483647
E/chromium(13749): *** Failure in ../../Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:45
E/chromium(13749): Value of: pow(2.0, 52) - 2
E/chromium(13749): Actual: 4.5036e+15
E/chromium(13749): Expected: lrint(pow(2.0, 52) - 1.5)
E/chromium(13749): Which is: 2147483647
E/chromium(13749): *** Failure in ../../Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:47
E/chromium(13749): Value of: -pow(2.0, 52)
E/chromium(13749): Actual: -4.5036e+15
E/chromium(13749): Expected: lrint(-pow(2.0, 52) + 0.5)
E/chromium(13749): Which is: -2147483648
E/chromium(13749): *** Failure in ../../Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:48
E/chromium(13749): Value of: -pow(2.0, 52) + 2
E/chromium(13749): Actual: -4.5036e+15
E/chromium(13749): Expected: lrint(-pow(2.0, 52) + 1.5)
E/chromium(13749): Which is: -2147483648
E/chromium(13749): [ FAILED ] WTF.Lrint
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Peter Beverloo
This was fixed in another patch by adding a sizeof(long int)==8 check around these asserts.