Bug 95664

Summary: [Shadow DOM] should be able to be available without <style scoped>
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dominicc, macpherson, menard, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 96315, 98244, 98842    
Bug Blocks: 94082    
Attachments:
Description Flags
Patch
none
Updated to ToT
none
Patch
none
Patch none

Hajime Morrita
Reported 2012-09-02 21:38:42 PDT
Since styling for Shadow DOM relies on scoped stylesheet internal implementation, Shadow DOM want it even when <style scoped> is disabled.
Attachments
Patch (11.87 KB, patch)
2012-09-03 03:23 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Updated to ToT (11.79 KB, patch)
2012-09-05 23:19 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (11.86 KB, patch)
2012-09-14 08:56 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (19.33 KB, patch)
2012-10-09 21:37 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-09-03 03:23:25 PDT
Created attachment 161892 [details] Patch
Hajime Morrita
Comment 2 2012-09-05 23:19:43 PDT
Created attachment 162425 [details] Updated to ToT
Hajime Morrita
Comment 3 2012-09-10 16:14:01 PDT
Comment on attachment 162425 [details] Updated to ToT Dimitri, do you think we need this?
Dimitri Glazkov (Google)
Comment 4 2012-09-10 16:16:14 PDT
Comment on attachment 162425 [details] Updated to ToT No, not at the moment.
Hajime Morrita
Comment 5 2012-09-14 08:56:43 PDT
Created attachment 164165 [details] Patch
Ryosuke Niwa
Comment 6 2012-09-17 13:52:39 PDT
Comment on attachment 164165 [details] Patch What should be available without scoped style element?
Hajime Morrita
Comment 7 2012-09-17 19:30:47 PDT
(In reply to comment #6) > (From update of attachment 164165 [details]) > What should be available without scoped style element? Style scoping using ShadowRoot.
Hajime Morrita
Comment 8 2012-09-20 18:44:08 PDT
*** Bug 92053 has been marked as a duplicate of this bug. ***
Hajime Morrita
Comment 9 2012-10-09 21:37:02 PDT
Created attachment 167914 [details] Patch
Hajime Morrita
Comment 10 2012-10-09 21:41:55 PDT
This one is ready! I hope I could eliminated more guards. But scope related code in css/ isn't cleanly separated from StyleResolver yet, that makes me hesitate to eliminate these flags. I'm thinking about how we could refactor it, but I'd like to land this before further refactoring so that we can make sure the styling feature to be available for Shadow DOM regardless of <style scoped> availability.
WebKit Review Bot
Comment 11 2012-10-10 18:00:38 PDT
Comment on attachment 167914 [details] Patch Clearing flags on attachment: 167914 Committed r130987: <http://trac.webkit.org/changeset/130987>
WebKit Review Bot
Comment 12 2012-10-10 18:00:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.