Bug 95277

Summary: JSC: adding support for adding LLInt opcode extensions
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix.
none
One more time after svn up. none

Mark Lam
Reported 2012-08-28 18:36:00 PDT
Adding support for adding LLInt opcode extensions. This will be needed by the LLInt C loop interpreter later. Currently, this change should have no effect on the behavior of existing code.
Attachments
Fix. (7.88 KB, patch)
2012-08-28 18:46 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
One more time after svn up. (7.88 KB, patch)
2012-08-28 18:49 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2012-08-28 18:46:08 PDT
Created attachment 161113 [details] Fix.
Mark Lam
Comment 2 2012-08-28 18:49:49 PDT
Created attachment 161114 [details] One more time after svn up.
Geoffrey Garen
Comment 3 2012-08-28 19:11:25 PDT
Comment on attachment 161114 [details] One more time after svn up. I like this idea of distinguishing between core opcodes emitted by the compiler and extension / optimization opcodes used by the engine. We could take this even further by separating out opcodes like op_get_by_id_* and op_put_by_id_*.
WebKit Review Bot
Comment 4 2012-08-28 19:24:30 PDT
Comment on attachment 161114 [details] One more time after svn up. Rejecting attachment 161114 [details] from review queue. ggaren@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Review Bot
Comment 5 2012-08-28 19:27:00 PDT
Comment on attachment 161114 [details] One more time after svn up. Rejecting attachment 161114 [details] from commit-queue. ggaren@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Geoffrey Garen
Comment 6 2012-08-28 20:16:36 PDT
Comment on attachment 161114 [details] One more time after svn up. Trying cq+ again.
WebKit Review Bot
Comment 7 2012-08-28 20:57:30 PDT
Comment on attachment 161114 [details] One more time after svn up. Clearing flags on attachment: 161114 Committed r126955: <http://trac.webkit.org/changeset/126955>
WebKit Review Bot
Comment 8 2012-08-28 20:57:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.