Bug 95249

Summary: [Mac] Add iconURL to WebNotification
Product: WebKit Reporter: Jon Lee <jonlee>
Component: DOMAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jberlin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.8   
Bug Depends on:    
Bug Blocks: 77969, 95232    
Attachments:
Description Flags
Patch jberlin: review+

Jon Lee
Reported 2012-08-28 14:46:50 PDT
On the WK1 side WebNotification was missing an accessor to the notification's iconURL. It is already available on WK2.
Attachments
Patch (1.82 KB, patch)
2012-08-28 14:51 PDT, Jon Lee 		jberlin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-08-28 14:47:02 PDT
<rdar://problem/12192060>
Jon Lee
Comment 2 2012-08-28 14:51:38 PDT
Created attachment 161065 [details] Patch
Alexey Proskuryakov
Comment 3 2012-08-29 09:32:39 PDT
Comment on attachment 161065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161065&action=review > Source/WebKit/mac/WebView/WebNotification.mm:118 > + ASSERT(core(self)); > + return core(self)->iconURL(); I'm not sure if this kind of ASSERT is useful. We'd get a very unambiguous crash in actual code, so there is no need to help debugging by adding the assertion.
Jon Lee
Comment 4 2012-08-29 10:06:16 PDT
(In reply to comment #3) > (From update of attachment 161065 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161065&action=review > > > Source/WebKit/mac/WebView/WebNotification.mm:118 > > + ASSERT(core(self)); > > + return core(self)->iconURL(); > > I'm not sure if this kind of ASSERT is useful. We'd get a very unambiguous crash in actual code, so there is no need to help debugging by adding the assertion. I can remove it, as well as all the other instances in the file.
Jon Lee
Comment 5 2012-08-29 10:12:06 PDT
Committed r127009: <http://trac.webkit.org/changeset/127009>
Note You need to log in before you can comment on or make changes to this bug.