Bug 95232

Summary: [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Tools / TestsAssignee: Jon Lee <jonlee>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap, jberlin, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.8   
Bug Depends on: 79492, 95249, 95505    
Bug Blocks: 77969    
Attachments:
Description Flags
Patch ap: review+

Jon Lee
Reported 2012-08-28 12:37:16 PDT
With this flag set, test output will include events that mimic what would happen on the platform level, such as a user clicking on a notification, or the platform showing a notification.
Attachments
Patch (9.75 KB, patch)
2012-08-29 14:00 PDT, Jon Lee 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-08-28 12:37:32 PDT
<rdar://problem/12190776>
Jon Lee
Comment 2 2012-08-29 14:00:21 PDT
Created attachment 161308 [details] Patch
Alexey Proskuryakov
Comment 3 2012-08-30 11:35:52 PDT
Comment on attachment 161308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161308&action=review > Tools/DumpRenderTree/mac/UIDelegate.mm:294 > + printf("REQUESTED WEB NOTIFICATION PERMISSION FOR %s\n", [[origin stringValue] UTF8String]); Should this be guarded by gTestRunner->dumpWebNotificationCallbacks?
Jon Lee
Comment 4 2012-08-30 11:36:29 PDT
Comment on attachment 161308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161308&action=review >> Tools/DumpRenderTree/mac/UIDelegate.mm:294 >> + printf("REQUESTED WEB NOTIFICATION PERMISSION FOR %s\n", [[origin stringValue] UTF8String]); > > Should this be guarded by gTestRunner->dumpWebNotificationCallbacks? Yes! Thank you.
Jon Lee
Comment 5 2012-08-30 12:45:49 PDT
Committed r127171: <http://trac.webkit.org/changeset/127171>
WebKit Review Bot
Comment 6 2012-08-30 15:01:26 PDT
Re-opened since this is blocked by 95505
Jon Lee
Comment 7 2012-08-30 15:10:57 PDT
ap did not feel that this additional output added value for tests, and that the javascript events should suffice. rolling out in bug 95505.
Note You need to log in before you can comment on or make changes to this bug.