Bug 94945

Summary:

[New Multicolumn] Plumbing to prepare for painting and hit testing implementation

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, peter+ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+, peter+ews: commit-queue-

Dave Hyatt

Reported 2012-08-24 09:34:44 PDT

Plumbing to prepare for painting and hit testing implementation.

Attachments
Patch (14.43 KB, patch) 2012-08-24 09:42 PDT, Dave Hyatt	mitz: review+ peter+ews: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2012-08-24 09:42:17 PDT

Created attachment 160438 [details] Patch

WebKit Review Bot

Comment 2 2012-08-24 09:44:02 PDT

Attachment 160438 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderRegion.h:101: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/rendering/RenderMultiColumnFlowThread.h:42: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/rendering/RenderRegionSet.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

mitz

Comment 3 2012-08-24 09:50:07 PDT

Comment on attachment 160438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160438&action=review > Source/WebCore/rendering/RenderMultiColumnSet.cpp:172 > - if (!columnCount()) > + unsigned colCount = columnCount(); > + if (!colCount) ?

Peter Beverloo (cr-android ews)

Comment 4 2012-08-24 10:18:20 PDT

Comment on attachment 160438 [details] Patch Attachment 160438 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13600200

Build Bot

Comment 5 2012-08-24 10:27:04 PDT

Comment on attachment 160438 [details] Patch Attachment 160438 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13600201

Dave Hyatt

Comment 6 2012-08-24 10:48:54 PDT

Fixed in r126602.

Note You need to log in before you can comment on or make changes to this bug.