Bug 94687

Summary: [EFL] Update pixel test expectations for layout test fast/forms/
Product: WebKit Reporter: KwangYong Choi <ky0.choi>
Component: New BugsAssignee: KwangYong Choi <ky0.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94188    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3
none
Patch
none
Patch none

KwangYong Choi
Reported 2012-08-22 03:28:27 PDT
[EFL] Update pixel test expectations for layout test fast/forms/
Attachments
Patch 1 (1.61 MB, patch)
2012-08-22 04:09 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch 2 (1.61 MB, patch)
2012-08-22 04:10 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch 3 (712.02 KB, patch)
2012-08-22 04:11 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch (deleted)
2012-08-22 19:20 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch (deleted)
2012-08-23 05:35 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
KwangYong Choi
Comment 1 2012-08-22 04:09:31 PDT
Created attachment 159899 [details] Patch 1 Uploaded pixel expectations are little bit different from original ones. Bugzilla has upload limit, so I splited patch to 3 pieces. Is it possible to upload like this?
KwangYong Choi
Comment 2 2012-08-22 04:10:23 PDT
Created attachment 159900 [details] Patch 2
KwangYong Choi
Comment 3 2012-08-22 04:11:00 PDT
Created attachment 159901 [details] Patch 3
KwangYong Choi
Comment 4 2012-08-22 19:20:54 PDT
Created attachment 160068 [details] Patch with big file option.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-08-22 19:33:36 PDT
fast/forms/listbox-hit-test-zoomed-expected.png looks wrong; it should be skipped and a bug report should be created. Ditto for menulist-restrict-line-height-expected.png, fast/forms/search-cancel-button-style-sharing-expected.png and fast/forms/search-rtl-expected.png. fast/forms/menulist-narrow-width-expected.png, fast/forms/select-baseline-expected.png and fast/forms/menulist-style-color-expected.png all seem to be suffering from the same regression. Perhaps fast/forms/select-style-expected.png is having the same bug as well. The scrollbar isn't being fully rendered in fast/forms/textarea-scroll-height-expected.png and fast/forms/textarea-scrolled-type-expected.png (I guess that's bug 85484).
KwangYong Choi
Comment 6 2012-08-23 00:07:51 PDT
(In reply to comment #5) > fast/forms/listbox-hit-test-zoomed-expected.png looks wrong; it should be skipped and a bug report should be created. > You're right. Test 2 is failing. I will make this test skip. > Ditto for menulist-restrict-line-height-expected.png, fast/forms/search-cancel-button-style-sharing-expected.png and fast/forms/search-rtl-expected.png. > For fast/forms/menulist-restrict-line-height.html, text in the popup button is clipped. Need skip. For fast/forms/search-cancel-button-style-sharing.html and fast/forms/search-rtl.html, cancel mark is not displayed on search box. Need skip. > fast/forms/menulist-narrow-width-expected.png, fast/forms/select-baseline-expected.png and fast/forms/menulist-style-color-expected.png all seem to be suffering from the same regression. Perhaps fast/forms/select-style-expected.png is having the same bug as well. > These tests have styling problem. Need skip. > The scrollbar isn't being fully rendered in fast/forms/textarea-scroll-height-expected.png and fast/forms/textarea-scrolled-type-expected.png (I guess that's bug 85484). These tests have scroll bar displaying problem. Need skip.
KwangYong Choi
Comment 7 2012-08-23 05:35:49 PDT
Created attachment 160136 [details] Patch The wrong test expectations will be removed by bug 94798.
Gyuyoung Kim
Comment 8 2012-08-23 05:48:17 PDT
Anyone double checking ?
Gyuyoung Kim
Comment 9 2012-08-23 06:33:09 PDT
Rebased .png flies pass --pixel test in my linux box.
Raphael Kubo da Costa (:rakuco)
Comment 10 2012-08-23 12:07:53 PDT
Comment on attachment 160136 [details] Patch Looks OK now, cq+'ing.
WebKit Review Bot
Comment 11 2012-08-23 12:26:09 PDT
Comment on attachment 160136 [details] Patch Clearing flags on attachment: 160136 Committed r126466: <http://trac.webkit.org/changeset/126466>
WebKit Review Bot
Comment 12 2012-08-23 12:26:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.