Bug 94297

Summary:

[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows

Product:

WebKit

Reporter:

yosin

Component:

Tools / Tests

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

94195

Attachments:

Description	Flags
Patch 1	none

yosin

Reported 2012-08-16 22:45:26 PDT

There are something wrong in date format detection code: function checkHasShortFormat() { var container = document.createElement("span"); container.innerHTML = "<input type=time id=step60 step=60><input type=time id=step1 step=1>"; document.body.appendChild(container); var hasShortFormat = document.getElementById("step60").offsetWidth != document.getElementById("step1").offsetWidth; container.parentElement.removeChild(container); return hasShortFormat; }

Attachments
Patch 1 (3.28 KB, patch) 2012-08-19 19:08 PDT, yosin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2012-08-19 19:08:48 PDT

Created attachment 159319 [details] Patch 1

yosin

Comment 2 2012-08-19 19:09:29 PDT

Comment on attachment 159319 [details] Patch 1 Could you review this patch? Thanks in advance.

Kent Tamura

Comment 3 2012-08-19 19:11:58 PDT

Comment on attachment 159319 [details] Patch 1 ok

yosin

Comment 4 2012-08-19 19:25:15 PDT

Comment on attachment 159319 [details] Patch 1 Clearing flags on attachment: 159319 Committed r125986: <http://trac.webkit.org/changeset/125986>

yosin

Comment 5 2012-08-19 19:25:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.