Bug 94186

Summary: [Tests] Disable fast/forms/time-multiple-fields tests for ports which don't enable multiple fields time input UI feature
Product: WebKit Reporter: yosin
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94166    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3 none

yosin
Reported 2012-08-15 22:00:47 PDT
Tests in fast/forms/time-multiple-fields/ are ports enabling both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. These tests should be skipped for ports which don't enable multiple field time input UI.
Attachments
Patch 1 (5.19 KB, patch)
2012-08-15 22:13 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (5.20 KB, patch)
2012-08-15 22:15 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (5.55 KB, patch)
2012-08-15 22:47 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-08-15 22:13:11 PDT
Created attachment 158709 [details] Patch 1
yosin
Comment 2 2012-08-15 22:15:30 PDT
Created attachment 158711 [details] Patch 2
yosin
Comment 3 2012-08-15 22:16:03 PDT
Comment on attachment 158711 [details] Patch 2 Could you review this patch? Thanks in advance.
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-08-15 22:42:00 PDT
I'd appreciate it if you could update TestExpectations instead of Skipped for the EFL port.
yosin
Comment 5 2012-08-15 22:47:35 PDT
Created attachment 158714 [details] Patch 3
yosin
Comment 6 2012-08-15 22:48:40 PDT
Comment on attachment 158714 [details] Patch 3 Could you review this patch? Thanks in advance. = Changes since the last review = * Change platform/efl/TestExpectations instead of Skipped
Kent Tamura
Comment 7 2012-08-15 22:58:19 PDT
Comment on attachment 158714 [details] Patch 3 ok
yosin
Comment 8 2012-08-15 22:59:51 PDT
Comment on attachment 158714 [details] Patch 3 Clearing flags on attachment: 158714 Committed r125748: <http://trac.webkit.org/changeset/125748>
yosin
Comment 9 2012-08-15 22:59:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.