Bug 94104

Summary: [EFL][WK2] Add unit tests for WKEinaSharedString
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90451    
Attachments:
Description Flags
patch
kenneth: review+
patch v2 none

Mikhail Pozdnyakov
Reported 2012-08-15 06:51:15 PDT
Unit tests for WKEinaSharedString are to be added.
Attachments
patch (5.97 KB, patch)
2012-08-20 01:52 PDT, Mikhail Pozdnyakov 		kenneth: review+
DetailsFormatted DiffDiff
patch v2 (6.01 KB, patch)
2012-08-20 03:38 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-08-20 01:52:16 PDT
Created attachment 159369 [details] patch
Kenneth Rohde Christiansen
Comment 2 2012-08-20 01:57:55 PDT
Comment on attachment 159369 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159369&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:42 > +static const char testString[] = "I'm test string!"; > +static const char anotherTestString[] = "I'm another test string!"; Why not make two alike here?
Mikhail Pozdnyakov
Comment 3 2012-08-20 03:38:24 PDT
Created attachment 159388 [details] patch v2 Use always different string objects.
WebKit Review Bot
Comment 4 2012-08-20 04:52:42 PDT
Comment on attachment 159388 [details] patch v2 Clearing flags on attachment: 159388 Committed r126019: <http://trac.webkit.org/changeset/126019>
WebKit Review Bot
Comment 5 2012-08-20 04:52:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.