Bug 93993

Summary: Rename DOMWindow::clear to something more descriptive
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75793    
Attachments:
Description Flags
Patch none

WebKit Review Bot
Reported 2012-08-14 10:24:52 PDT
Rename DOMWindow::clear to something more descriptive Requested by abarth on #webkit.
Attachments
Patch (5.71 KB, patch)
2012-08-16 15:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-16 15:46:31 PDT
Created attachment 158930 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-16 15:51:47 PDT
Comment on attachment 158930 [details] Patch OK. I take it resetDOMWindowProperties doesn't actually zero them? :)
Adam Barth
Comment 3 2012-08-16 15:53:33 PDT
> OK. I take it resetDOMWindowProperties doesn't actually zero them? :) It does zero them out. We can leave that name as "clear" if you think that's better.
WebKit Review Bot
Comment 4 2012-08-16 17:29:50 PDT
Comment on attachment 158930 [details] Patch Clearing flags on attachment: 158930 Committed r125832: <http://trac.webkit.org/changeset/125832>
WebKit Review Bot
Comment 5 2012-08-16 17:29:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.