Bug 93807

Summary: [V8] Remove V8BindingHelpers
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gyuyoung.kim, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93095    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-08-13 02:11:20 PDT
V8BindingHelpers contains toV8Context() and toV8Proxy(), which are used by NPV8Object.cpp only. (1) Move these methods to NPV8Object.cpp as static methods. (2) Remove V8BindingHelpers.{h,cpp}.
Attachments
Patch (8.71 KB, patch)
2012-08-13 02:14 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-13 02:14:28 PDT
Created attachment 157943 [details] Patch
Adam Barth
Comment 2 2012-08-13 10:27:47 PDT
Comment on attachment 157943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157943&action=review > Source/WebCore/bindings/v8/NPV8Object.cpp:67 > + if (!domWindow || !domWindow->frame() || domWindow != domWindow->frame()->domWindow()) This line of code is so broken. I'll fix it as part of Bug 75793.
Kentaro Hara
Comment 3 2012-08-13 17:45:01 PDT
Committed r125479: <http://trac.webkit.org/changeset/125479>
Note You need to log in before you can comment on or make changes to this bug.