Bug 93779

Summary: Update text track computed line position algorithm
Product: WebKit Reporter: Victor Carbune <vcarbune>
Component: MediaAssignee: Victor Carbune <vcarbune>
Status: RESOLVED FIXED    
Severity: Normal CC: annacc, eric.carlson, feature-media-reviews, silviapf, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79347    
Attachments:
Description Flags
Proposed patch none

Victor Carbune
Reported 2012-08-12 06:51:22 PDT
The computed line position (TextTrackCue::calculateComputedLinePosition) should determine the track index considering only rendered tracks (have showing or showing by default mode).
Attachments
Proposed patch (9.70 KB, patch)
2012-11-14 14:16 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2012-11-14 14:15:58 PST
This defect causes tracks that are not rendered to affect the position of cues from tracks that are rendered. For example, if a video element has three <track> elements and only the third one is rendered, its cues will not be positioned as though all three tracks are enabled.
Eric Carlson
Comment 2 2012-11-14 14:16:26 PST
Created attachment 174258 [details] Proposed patch
Silvia Pfeiffer
Comment 3 2012-11-14 14:27:31 PST
FWIW: the patch looks good to me
Philippe Normand
Comment 4 2012-11-15 08:20:47 PST
Comment on attachment 174258 [details] Proposed patch LGTM!
WebKit Review Bot
Comment 5 2012-11-15 08:42:42 PST
Comment on attachment 174258 [details] Proposed patch Rejecting attachment 174258 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14847436
Eric Carlson
Comment 6 2012-11-15 09:07:11 PST
http://trac.webkit.org/changeset/134783
Note You need to log in before you can comment on or make changes to this bug.