Bug 93638

Summary: [WK2] Unskip tests requiring layoutTestController.dumpResourceResponseMIMETypes
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit2Assignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, eric, kenneth, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2012-08-09 12:11:34 PDT
Tests requiring layoutTestController.dumpResourceResponseMIMETypes can be unskipped as https://bugs.webkit.org/show_bug.cgi?id=93454 is landed.
Attachments
patch (2.67 KB, patch)
2012-08-09 12:18 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-08-09 12:18:38 PDT
Created attachment 157511 [details] patch Unfortunately I do not have an opportunity to check that platform/mac/.. tests pass, so keep them skipped so far.
Alexey Proskuryakov
Comment 2 2012-08-09 13:00:14 PDT
Tests 2 and 3 passed for me on Mac, but the first one failed: -example-dng.dng has MIME type application/octet-stream +example-dng.dng has MIME type image/x-adobe-dng This probably depends on whether one has Adobe software installed. It's not a very useful test overall, as it mostly reports what lower level OS components tell us, not about anything in WebKit.
WebKit Review Bot
Comment 3 2012-08-09 13:12:15 PDT
Comment on attachment 157511 [details] patch Rejecting attachment 157511 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/PerformanceTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13457937
Alexey Proskuryakov
Comment 4 2012-08-09 13:30:10 PDT
The failure looks like a commit queue issue to me.
Adam Barth
Comment 5 2012-08-09 13:33:30 PDT
Interesting. The regexp for "Unreviewed" must be too tight.
Eric Seidel (no email)
Comment 6 2012-08-09 13:37:41 PDT
Maybe something changed recently in the ChangeLog.py class. Or maybe this particular instance just got confused somehow.
Alexey Proskuryakov
Comment 7 2012-08-09 13:41:06 PDT
Someone pointed out on IRC that this is not a unique occurrence, see <https://bugs.webkit.org/show_bug.cgi?id=90959#c44>.
Eric Seidel (no email)
Comment 8 2012-08-09 13:43:49 PDT
The checkout got corrupted on one of the instances. Adam is fixing.
WebKit Review Bot
Comment 9 2012-08-09 15:51:30 PDT
Comment on attachment 157511 [details] patch Clearing flags on attachment: 157511 Committed r125215: <http://trac.webkit.org/changeset/125215>
WebKit Review Bot
Comment 10 2012-08-09 15:51:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.