Bug 93599

Summary: Invalid Content Security Policy sources should generate console warnings.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93197    
Attachments:
Description Flags
Patch none

Mike West
Reported 2012-08-09 01:58:35 PDT
`script-src 'slef'`, `script-src http:/`, and so on should not only be ignored when parsing a page's Content Security Policy, but should also generate a warning so that the developer's expectations are correctly set.
Attachments
Patch (14.38 KB, patch)
2012-08-09 05:06 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-08-09 05:06:57 PDT
Created attachment 157437 [details] Patch
Mike West
Comment 2 2012-08-09 05:10:53 PDT
This patch updates CSP to throw moar warnings. WDYT, Adam?
Mike West
Comment 3 2012-08-09 11:31:14 PDT
Comment on attachment 157437 [details] Patch Thanks. CQ? (soon...)
WebKit Review Bot
Comment 4 2012-08-09 12:54:03 PDT
Comment on attachment 157437 [details] Patch Rejecting attachment 157437 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: CT (content): Merge conflict in LayoutTests/ChangeLog Failed to merge in the changes. Patch failed at 0001 (r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13473067
WebKit Review Bot
Comment 5 2012-08-09 15:37:14 PDT
Comment on attachment 157437 [details] Patch Clearing flags on attachment: 157437 Committed r125213: <http://trac.webkit.org/changeset/125213>
WebKit Review Bot
Comment 6 2012-08-09 15:37:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.