Bug 93595

Summary: [V8] Rename V8BindingPerContextData to V8PerContextData
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gyuyoung.kim, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93095    
Attachments:
Description Flags
Patch
none
patch for landing
webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-08-09 01:33:14 PDT
For a better name. See discussion in bug 93333.
Attachments
Patch (33.82 KB, patch)
2012-08-09 01:40 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (33.80 KB, patch)
2012-08-09 16:44 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (33.93 KB, patch)
2012-08-09 18:01 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-09 01:40:18 PDT
Created attachment 157423 [details] Patch
Adam Barth
Comment 2 2012-08-09 09:45:16 PDT
Comment on attachment 157423 [details] Patch The bug title was slightly off. You might want to update the ChangeLog before landing.
Kentaro Hara
Comment 3 2012-08-09 16:44:06 PDT
Created attachment 157578 [details] patch for landing
WebKit Review Bot
Comment 4 2012-08-09 17:55:11 PDT
Comment on attachment 157578 [details] patch for landing Rejecting attachment 157578 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing file Source/WebCore/bindings/v8/V8PerContextData.cpp patching file Source/WebCore/bindings/v8/V8PerContextData.h patching file Source/WebCore/bindings/v8/V8Proxy.cpp patching file Source/WebCore/bindings/v8/V8Proxy.h patching file Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp patching file Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13461700
Kentaro Hara
Comment 5 2012-08-09 18:01:23 PDT
Created attachment 157599 [details] patch for landing
WebKit Review Bot
Comment 6 2012-08-09 20:05:25 PDT
Comment on attachment 157599 [details] patch for landing Clearing flags on attachment: 157599 Committed r125242: <http://trac.webkit.org/changeset/125242>
Note You need to log in before you can comment on or make changes to this bug.