Bug 93466

Summary: Extract the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: ImagesAssignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gustavo, hclam, simon.fraser, skyul, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93573    
Bug Blocks: 90375, 93467    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Dongseong Hwang
Reported 2012-08-08 05:08:34 PDT
Image.h includes ImageSource.h in order to know the definition of NativeImagePtr. But Image does not need to know the definition of ImageSource. So, this patch extracts the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h. This is a preparation for asynchronous image decoding. Async decoding will need a callback function, which sends a NativeImagePtr to clients, and the callback must know the definition of NativeImagePtr, not ImageSource.
Attachments
Patch (13.06 KB, patch)
2012-08-08 05:09 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.79 KB, patch)
2012-08-08 18:44 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.82 KB, patch)
2012-08-09 05:54 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-08-08 05:09:47 PDT
Created attachment 157186 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-08-08 06:54:34 PDT
Comment on attachment 157186 [details] Patch Attachment 157186 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13455502
Hin-Chung Lam
Comment 3 2012-08-08 08:51:35 PDT
+1 I like this is separated.
Adam Barth
Comment 4 2012-08-08 10:04:41 PDT
Comment on attachment 157186 [details] Patch Ok. Looks like you've got a build issue on GTK to resolve before landing.
Kwang Yul Seo
Comment 5 2012-08-08 14:40:18 PDT
(In reply to comment #4) > (From update of attachment 157186 [details]) > Ok. Looks like you've got a build issue on GTK to resolve before landing. Thanks. I will land the patch after fixing the build issue.
Kwang Yul Seo
Comment 6 2012-08-08 17:39:52 PDT
Comment on attachment 157186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157186&action=review > Source/WebCore/platform/graphics/NativeImagePtr.h:2 > + * Copyright (C) 2012 Company 100 Inc. All rights reserved. I think we should keep the original copyright of ImageSource.h because this patch simply copies the definition of NativeImagePtr from ImageSource.h. Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved. Copyright (C) 2007-2008 Torch Mobile, Inc.
Dongseong Hwang
Comment 7 2012-08-08 18:42:45 PDT
Thank all for review.
Kwang Yul Seo
Comment 8 2012-08-08 18:44:22 PDT
Created attachment 157363 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-08-08 19:31:59 PDT
Comment on attachment 157363 [details] Patch for landing Rejecting attachment 157363 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13451995
Kwang Yul Seo
Comment 10 2012-08-08 19:36:02 PDT
Committed r125143: <http://trac.webkit.org/changeset/125143>
WebKit Review Bot
Comment 11 2012-08-08 20:17:56 PDT
Re-opened since this is blocked by 93573
Kwang Yul Seo
Comment 12 2012-08-09 05:54:13 PDT
Created attachment 157458 [details] Patch for landing
WebKit Review Bot
Comment 13 2012-08-09 13:10:24 PDT
Comment on attachment 157458 [details] Patch for landing Rejecting attachment 157458 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [chromium] Pass mask scale and offset to shaders for correct masking When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13457935
WebKit Review Bot
Comment 14 2012-08-09 14:25:47 PDT
Comment on attachment 157458 [details] Patch for landing Clearing flags on attachment: 157458 Committed r125203: <http://trac.webkit.org/changeset/125203>
WebKit Review Bot
Comment 15 2012-08-09 14:25:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.