Bug 93452

Summary: EventDispatcher::dispatchSimulatedClick should not reuse the same EventDispatcher instance.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: UI EventsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91290    
Attachments:
Description Flags
fix simulatedClick none

Hayato Ito
Reported 2012-08-08 01:47:41 PDT
This is a follow up issue after https://bugs.webkit.org/show_bug.cgi?id=93322. There is yet another place where the same EventDispatcher instance is reused across event dispatching. In addition to that, in order to simulate a real click, we must use the different dispatchers because we must recalculate event ancestors each time. Current implementation wrongly freezes event ancestors at the first event dispatch.
Attachments
fix simulatedClick (4.34 KB, patch)
2012-08-08 01:55 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-08-08 01:55:03 PDT
Created attachment 157153 [details] fix simulatedClick
WebKit Review Bot
Comment 2 2012-08-08 18:11:51 PDT
Comment on attachment 157153 [details] fix simulatedClick Clearing flags on attachment: 157153 Committed r125133: <http://trac.webkit.org/changeset/125133>
WebKit Review Bot
Comment 3 2012-08-08 18:11:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.