Bug 93410

Summary: IndexedDB: new enums and openCursor stub
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebCore Misc.Assignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dgrogan, fishd, jamesr, jsbell, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91125    
Attachments:
Description Flags
Patch
none
Patch none

Alec Flett
Reported 2012-08-07 16:45:28 PDT
IndexedDB: new enums and openCursor stub
Attachments
Patch (5.91 KB, patch)
2012-08-07 16:49 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (5.86 KB, patch)
2012-08-08 09:37 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2012-08-07 16:49:43 PDT
Created attachment 157044 [details] Patch
WebKit Review Bot
Comment 2 2012-08-07 16:51:01 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Alec Flett
Comment 3 2012-08-07 16:52:16 PDT
Only open choice at this point is naming on "EarlyTask" - these are basically higher-priority, internal tasks. for the full landing of bug 91125, these are specifically continueFunctionInternal and setIndexesReady (also stubbed out in this patch) jsbell, dgrogan, any input is welcome on naming - the rest of the patch is fairly dull.
David Grogan
Comment 4 2012-08-07 18:36:53 PDT
Comment on attachment 157044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157044&action=review > Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h:54 > + EarlyTask // InternalTask? GardeningTask? HighPriorityTask? PreemptiveTask? > Source/WebKit/chromium/public/WebIDBObjectStore.h:29 > #include "WebDOMStringList.h" Heh, fail.
Joshua Bell
Comment 5 2012-08-07 20:44:20 PDT
(In reply to comment #4) > (From update of attachment 157044 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157044&action=review > > > Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h:54 > > + EarlyTask // InternalTask? GardeningTask? > > HighPriorityTask? PreemptiveTask? I like PreemptiveTask. Does this need to be in Interface or can it be in Impl?
Joshua Bell
Comment 6 2012-08-07 20:45:45 PDT
(In reply to comment #5) > > Does this need to be in Interface or can it be in Impl? Never mind, I see how it's used now.
Alec Flett
Comment 7 2012-08-08 09:37:50 PDT
Created attachment 157238 [details] Patch
Alec Flett
Comment 8 2012-08-08 09:39:14 PDT
tkent@ - r? just stubbing some stuff out for a chromium landing
Alec Flett
Comment 9 2012-08-08 13:35:56 PDT
(keep forgetting about timezones...) abarth@ - r?
Adam Barth
Comment 10 2012-08-08 13:39:12 PDT
Comment on attachment 157238 [details] Patch ok
WebKit Review Bot
Comment 11 2012-08-08 14:04:52 PDT
Comment on attachment 157238 [details] Patch Clearing flags on attachment: 157238 Committed r125084: <http://trac.webkit.org/changeset/125084>
WebKit Review Bot
Comment 12 2012-08-08 14:04:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.