Bug 93254

Summary: [V8] Move V8BindingMacros.h from bindings/v8/custom/ to bindings/v8/
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93095    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-08-06 04:23:34 PDT
V8BindingMacros.h should exist in bindings/v8/.
Attachments
Patch (8.47 KB, patch)
2012-08-06 04:25 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (8.31 KB, patch)
2012-08-07 17:28 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-06 04:25:39 PDT
Created attachment 156657 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-07 15:18:26 PDT
Comment on attachment 156657 [details] Patch rs=me.
WebKit Review Bot
Comment 3 2012-08-07 16:43:09 PDT
Comment on attachment 156657 [details] Patch Rejecting attachment 156657 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12253 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 31>At revision 12253. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13448757
Kentaro Hara
Comment 4 2012-08-07 17:28:06 PDT
Created attachment 157053 [details] patch for landing
WebKit Review Bot
Comment 5 2012-08-07 21:07:29 PDT
Comment on attachment 157053 [details] patch for landing Clearing flags on attachment: 157053 Committed r124978: <http://trac.webkit.org/changeset/124978>
Note You need to log in before you can comment on or make changes to this bug.