Bug 93239

Summary: [V8] Factor out V8Binding methods about configuring DOM attributes and methods
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gyuyoung.kim, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93095    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-08-06 02:27:49 PDT
V8Binding is messy. We can factor out V8Binding methods about configuring DOM attributes and methods into another file.
Attachments
Patch (20.22 KB, patch)
2012-08-06 02:31 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-06 02:31:08 PDT
Created attachment 156635 [details] Patch
Adam Barth
Comment 2 2012-08-07 15:22:49 PDT
Comment on attachment 156635 [details] Patch I would take this opportunity to change these files into WebKit style (e.g., not 80 column). Consider turning these functions into static functions in a class: V8DOMConfiguration::batchConfigureAttributes(...) You don't have to do these things, but it's nice to clean up this stuff as we touch it.
Kentaro Hara
Comment 3 2012-08-07 15:23:45 PDT
Comment on attachment 156635 [details] Patch Sounds nice. I'll fix it in a follow-up patch.
WebKit Review Bot
Comment 4 2012-08-07 16:38:41 PDT
Comment on attachment 156635 [details] Patch Clearing flags on attachment: 156635 Committed r124940: <http://trac.webkit.org/changeset/124940>
WebKit Review Bot
Comment 5 2012-08-07 16:38:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.