Bug 93222

Summary:

[chromium] Update CSS of video controls

Product:

WebKit

Reporter:

Silvia Pfeiffer <silviapf>

Component:

Media

Assignee:

Silvia Pfeiffer <silviapf>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

cmarcelo, dglazkov, eric.carlson, eric, feature-media-reviews, fishd, macpherson, mal, menard, schenney, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84672

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from gce-cr-linux-07	none
Added to wk89344 rebaselines	none

Silvia Pfeiffer

Reported 2012-08-05 20:23:45 PDT

Designer found bugs in CSS of Chrome video controls: grey background shade incorrect; volume slider width incorrect

Attachments
Patch (2.19 KB, patch) 2012-08-05 20:34 PDT, Silvia Pfeiffer	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-07 (1.98 MB, application/zip) 2012-08-05 23:10 PDT, WebKit Review Bot	no flags	Details
Added to wk89344 rebaselines (3.88 KB, patch) 2012-09-11 00:21 PDT, Silvia Pfeiffer	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Silvia Pfeiffer

Comment 1 2012-08-05 20:34:59 PDT

Created attachment 156589 [details] Patch

WebKit Review Bot

Comment 2 2012-08-05 23:10:23 PDT

Comment on attachment 156589 [details] Patch Attachment 156589 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13437649 New failing tests: media/audio-repaint.html fast/loader/loadInProgress.html media/audio-controls-rendering.html fast/loader/unload-form-post-about-blank.html fast/hidpi/video-controls-in-hidpi.html media/video-empty-source.html fast/canvas/webgl/shader-precision-format.html media/controls-styling-strict.html media/video-zoom-controls.html http/tests/xmlhttprequest/zero-length-response.html http/tests/security/script-crossorigin-loads-correctly.html media/controls-without-preload.html media/controls-after-reload.html media/media-document-audio-repaint.html platform/chromium/virtual/gpu/fast/canvas/webgl/shader-precision-format.html fast/frames/cached-frame-counter.html media/controls-styling.html http/tests/media/video-buffered-range-contains-currentTime.html media/video-controls-rendering.html media/media-controls-clone.html fast/layers/video-layer.html media/video-playing-and-pause.html fullscreen/full-screen-stacking-context.html media/video-no-audio.html media/controls-strict.html media/video-display-toggle.html media/controls-layout-direction.html

WebKit Review Bot

Comment 3 2012-08-05 23:10:28 PDT

Created attachment 156599 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Eric Seidel (no email)

Comment 4 2012-08-11 02:57:32 PDT

This is not a technical review. This is an authority review. I don't know who is in charge of the video control look/feel. If you are, then great, I'm happy to r+ this. Obviously you'll need to do some gardening when you land. :)

Silvia Pfeiffer

Comment 5 2012-08-11 03:47:11 PDT

Thanks, I want to wait with landing this until I have a bunch of patches together. There's still lots to change on the controls before Ken will be happy.

Silvia Pfeiffer

Comment 6 2012-09-11 00:21:47 PDT

Created attachment 163291 [details] Added to wk89344 rebaselines

WebKit Review Bot

Comment 7 2012-09-11 06:30:35 PDT

Comment on attachment 163291 [details] Added to wk89344 rebaselines Attachment 163291 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13818354 New failing tests: fullscreen/full-screen-stacking-context.html

Note You need to log in before you can comment on or make changes to this bug.