Bug 93220

Summary: [V8] Replace all V8 undefined values in the rest of V8 bindings with v8Undefined()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93095    
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-08-05 19:15:25 PDT
We should use v8Undefined() everywhere in V8 bindings. In this bug, we replace all V8 undefined values in the rest of custom bindings with v8Undefined().
Attachments
Patch (5.00 KB, patch)
2012-08-05 19:18 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (5.87 KB, patch)
2012-08-05 19:51 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-05 19:18:52 PDT
Created attachment 156585 [details] Patch
Kentaro Hara
Comment 2 2012-08-05 19:51:15 PDT
Created attachment 156586 [details] Patch
Eric Seidel (no email)
Comment 3 2012-08-07 15:21:33 PDT
Comment on attachment 156586 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2012-08-07 16:32:06 PDT
Comment on attachment 156586 [details] Patch Clearing flags on attachment: 156586 Committed r124938: <http://trac.webkit.org/changeset/124938>
WebKit Review Bot
Comment 5 2012-08-07 16:32:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.